Skip to content

Shipping Labels: Fix the UI glitch on the shipment detail bottom sheet #15940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2025
Merged

Shipping Labels: Fix the UI glitch on the shipment detail bottom sheet #15940

merged 2 commits into from
Jul 25, 2025

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jul 23, 2025 •
edited
Loading

Closes WOOMOB-648

Description

There is a UI glitch on the shipment detail bottom sheet when swiping the app to the background while the purchase form is displayed.

When swiping the app, the drag gesture on the bottom sheet is triggered but never ends due to the app resigning from the active state.

This PR fixes the glitch by resetting the revealContentDuringDrag state to false when the app re-enters the foreground. This makes sure that the bottom sheet is reset to its pre-dragged state.

Testing steps

  1. Log in to a test store with the Woo Shipping extension set up.
  2. Navigate to the Orders tab and select an order eligible for creating shipping labels.
  3. Select Create shipping label to open the purchase form.
  4. Quickly swipe to send the app to the background.
  5. Reopen the app and confirm that the bottom sheet UI doesn't have any glitch.

Testing information

Tested and confirmed with iPhone 16 Pro iOS 18.3.

Screenshots

Before:

ScreenRecording_07-23-2025.14-58-27_1.mov

After:

ScreenRecording_07-23-2025.14-55-51_1.mov
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 22.9 milestone Jul 23, 2025
@itsmeichigo itsmeichigo added feature: shipping labels Related to creating, ordering, or printing shipping labels. Bug labels Jul 23, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jul 23, 2025 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 22.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@itsmeichigo itsmeichigo marked this pull request as ready for review July 23, 2025 08:01
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 23, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15940-5a89d19
Version22.8
Bundle IDcom.automattic.alpha.woocommerce
Commit5a89d19
Installation URL1t56thgd09g6g
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

RafaelKayumov
RafaelKayumov approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@RafaelKayumov RafaelKayumov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelKayumov RafaelKayumov force-pushed the woomob-648-shipping-labels-shipment-details-arrow-layout-gets-corrupted branch from 2163c7a to 5a89d19 Compare July 25, 2025 10:11
@RafaelKayumov RafaelKayumov merged commit c1f0679 into trunk Jul 25, 2025
13 checks passed
@RafaelKayumov RafaelKayumov deleted the woomob-648-shipping-labels-shipment-details-arrow-layout-gets-corrupted branch July 25, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelKayumov RafaelKayumov RafaelKayumov approved these changes

Assignees

No one assigned

Labels

Bug feature: shipping labels Related to creating, ordering, or printing shipping labels.

Projects

None yet

Milestone

22.9

Development

Successfully merging this pull request may close these issues.

5 participants

@itsmeichigo @dangermattic @wpmobilebot @RafaelKayumov